Fix Vulkan resource cleanup in hello_xr - #612
Open
HussainAther wants to merge 1 commit into
Open
Conversation
HussainAther
force-pushed
the
fix/hello-xr-vulkan-cleanup
branch
from
July 19, 2026 22:34
2ff0bf6 to
17ce484
Compare
Collaborator
|
An issue (number 2785) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2785 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
|
This looks like a good change to me but as I compare it to the equivalent code in the conformance test suite I'm seeing divergence. Generally we've tried to keep these inline - if there's a way to keep them more similar that'd be great. But generally LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add explicit cleanup for Vulkan resources owned by
VulkanGraphicsPlugin.The destructor now:
This prevents
hello_xrfrom leaking its Vulkan device and instance and allows validation layers to report resource leaks more accurately.Fixes #211.
Testing
cmake --build buildctest --test-dir buildResult: