review: exact --cases selection, fail-fast on unknown ids#257
Open
jwbron wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 820c735 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Review live A/BNo reviewable delta: review.md is byte-identical in both arms (baseline |
khan-actions-bot
requested review from
a team,
jaredly and
somewhatabstract
and removed request for
a team
…st on unknown ids The smoke scope filtered the corpus before the case filter, so a powered dispatch naming a non-smoke case silently dropped it: the anchor-snap pricing run named two cases and the paid report covered one without saying so. --cases is now an exact selection (bypasses --smoke-only, preserves order, dedupes) and any id matching no live case throws before a single model call. The workflow needs no change; it already passes both flags and the case list now wins.
jwbron
force-pushed
the
jwbron/eval-case-selection
branch
from
a910f21 to
820c735
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instrument fix, stacked on #255 (parallel to #256), from a footgun the anchor-snap eval gate hit live.
What happened: the #255 powered dispatch (
cases=adversarial-injection-approve,golden-request-changes-authz repeats=10) followed the memo's recipe, which omitsfull=true. The workflow applies--smoke-onlybefore--cases, so the non-smokegolden-request-changes-authzwas silently filtered out of a paid measurement: the report covered one case with nothing anywhere saying the other was requested and dropped. A typo'd case id would shrink a measurement the same way. Re-measuring cost a second dispatch.The fix: an explicit
--caseslist is an exact selection.--smoke-only, which now scopes unscoped runs only (naming a case means selecting it; a tag filter should not second-guess an explicit list).Selection is extracted to a pure
selectCaseswith unit tests (smoke scope on/off, exact selection past the scope, order/dedup, unknown-id failure). The workflow yml needs no change: it already passes both flags, and the case list now wins. The memo's powered-run recipe works as written after this.