Skip to content

feat: prefer response status assertions - #121

Merged
hughgrigg merged 1 commit into
mainfrom
codex/feat/prefer-response-status-assertions
Aug 31, 2026
Merged

feat: prefer response status assertions#121
hughgrigg merged 1 commit into
mainfrom
codex/feat/prefer-response-status-assertions

Conversation

@hughgrigg

Copy link
Copy Markdown
Contributor

Summary

  • suggest assertResponseStatus(response, expectedStatus, await describeResponse(response)) for numeric .status assertions in ESLint and Oxlint
  • cover direct, strict, loose, and negated equality forms
  • promote describeResponse in the assertion and lint documentation
  • leave string-valued application statuses unchanged

Testing

  • pnpm check
  • pnpm build

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ac8ecc83-d863-4da9-b85d-91a0f4067aac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@hughgrigg
hughgrigg enabled auto-merge (squash) August 31, 2026 09:34
@hughgrigg
hughgrigg force-pushed the codex/feat/prefer-response-status-assertions branch from a21262f to 793f765 Compare August 31, 2026 09:36
@hughgrigg
hughgrigg merged commit ae3f116 into main Aug 31, 2026
3 checks passed
@hughgrigg
hughgrigg deleted the codex/feat/prefer-response-status-assertions branch August 31, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant