Repository navigation
Add paused_by information to ActiveTasks - #32
Merged
Merged
Conversation
tanelikor
approved these changes
Sep 14, 2026
tanelikor
left a comment
tanelikor
left a comment
Member
There was a problem hiding this comment.
Looks good. Agreed, its a bit ugly to have some argument lists grow this much and needing to pass the information through multiple layers, but I can't quickly think of a better solution for now. The proper solution would be to refactor this so that we don't need to pass these operations via ActiveTasks (have it function only as a tracker and not an operator) like we discussed last week, but that is better done as a separate refactor (and needs some more careful planning).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paused_by field can tell "who" or "why" the task has been paused. This information is to be provided by the client calling the pause task. Resume task automatically clears this field.
Not super happy with the current state, but maybe we can find some way to make this all nicer on the last refactors before the pausing feature is finally merged to main... Unless reviewers here come up with great ideas.