Repository navigation
fix: enforce config blocklist in render_and_apply_j2_template - #32
Merged
Merged
Conversation
check_config_blocklist (block.cfg) was only wired into load_and_commit_config. render_and_apply_j2_template rendered a Jinja2 template and committed it straight to devices without ever checking the blocklist, letting the same blocked patterns (e.g. root-authentication, login user credentials) bypass the guardrail via the template path.
Collaborator
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_config_blocklist (block.cfg) was only wired into load_and_commit_config. render_and_apply_j2_template rendered a Jinja2 template and committed it straight to devices without ever checking the blocklist, letting the same blocked patterns bypass the guardrail via the template path.