Small correctness and hygiene fixes - #136
Open
alecloudenback wants to merge 4 commits into
Open
alecloudenback wants to merge 4 commits into
alecloudenback wants to merge 4 commits into
Conversation
The error message contained the literal text `table_name` because the interpolation sigil was missing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFnc6pvofuNXTW2xdCcewT
Both were non-const global bindings, so every call through them was type-unstable. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFnc6pvofuNXTW2xdCcewT
It was referenced nowhere and evaluated the artifact path at precompile time, baking an absolute depot path into the image. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFnc6pvofuNXTW2xdCcewT
Custom tables printed a broken link ending in TableIdentity=nothing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFnc6pvofuNXTW2xdCcewT
This was referenced Sep 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four independent fixes, one commit each. No behavior change beyond the fixes themselves.
Changes
get_SOA_table"not found" error message now interpolates the requested name (it printed the literal texttable_name).ωandtableareconstaliases; both were non-const globals, so every call through them was type-unstable.table_dirsglobal is deleted. It evaluated the artifact path at precompile time and baked an absolute depot path into the image.showon aMortalityTableprints the mort.SOA.org id and link only when the table has an id. Custom tables printed a broken link ending inTableIdentity=nothing.Testing
showon a custom table.First of a 13-PR stack executing the v3.0.0 refactor plan; targets
master. The next PR in the stack is based on this branch.🤖 Generated with Claude Code
https://claude.ai/code/session_01JFnc6pvofuNXTW2xdCcewT