Fix Ticker Default Rivalries Labeling - #8942
Open
nyxsky404 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
@nyxsky404 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request addresses issue #8611 by improving the clarity of the ticker UI. The default compare ticker entries are now labeled as 'Example comparisons', which helps distinguish them from live rankings. This change is a small but important enhancement to user experience. It aligns with our ongoing efforts to improve UI clarity, similar to past decisions like adding a dark/light preview background toggle. Thank you for your contribution! |
4 tasks
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)
📊 Summary of Totals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8611
Default Compare ticker entries are hardcoded sample pairs, but the UI presented them like live rankings. Added an "Example comparisons" label and region aria-label when the built-in mock list is shown. Custom rivalry lists keep the existing "Top rivalries" labeling.
Pillar
Visual Preview
N/A — labeling change on Compare ticker.
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.Made with Cursor