Skip to content

Fix Ticker Default Rivalries Labeling - #8942

Open
nyxsky404 wants to merge 1 commit into
JhaSourav07:mainfrom
nyxsky404:fix/ticker-example-rivalries-label
Open

Fix Ticker Default Rivalries Labeling#8942
nyxsky404 wants to merge 1 commit into
JhaSourav07:mainfrom
nyxsky404:fix/ticker-example-rivalries-label

Conversation

@nyxsky404

Copy link
Copy Markdown
Contributor

Description

Fixes #8611

Default Compare ticker entries are hardcoded sample pairs, but the UI presented them like live rankings. Added an "Example comparisons" label and region aria-label when the built-in mock list is shown. Custom rivalry lists keep the existing "Top rivalries" labeling.

Pillar

  • Pillar 1 — New Theme Design
  • Pillar 2 — Geometric SVG Improvement
  • Pillar 3 — Timezone Logic Optimization
  • Other (Bug fix, refactoring, docs)

Visual Preview

N/A — labeling change on Compare ticker.

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI lite review requested due to automatic review settings August 6, 2026 11:18
@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@nyxsky404 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@retenta-bot

retenta-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

This pull request addresses issue #8611 by improving the clarity of the ticker UI. The default compare ticker entries are now labeled as 'Example comparisons', which helps distinguish them from live rankings. This change is a small but important enhancement to user experience. It aligns with our ongoing efforts to improve UI clarity, similar to past decisions like adding a dark/light preview background toggle. Thank you for your contribution!

@retenta-bot retenta-bot Bot changed the title fix(ticker): label default rivalries as example comparisons Fix Ticker Default Rivalries Labeling Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

Asset PR Size Base Size Difference Status
static/chunks/app/compare/page-[hash].js 17.80 KB 17.70 KB +0.10 KB (+0.56%) 🔴 Regression

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 4939.70 KB 4939.27 KB +0.43 KB (+0.01%)
Total CSS 348.51 KB 348.46 KB +0.05 KB (+0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Top Rivalries ticker presents a fixed example list as rankings

2 participants