Skip to content

fix(deps): resolve bcryptjs dependency for notification unit tests - #8930

Open
nishtha-agarwal-211 wants to merge 1 commit into
JhaSourav07:mainfrom
nishtha-agarwal-211:fix/bcryptjs-import-resolution
Open

fix(deps): resolve bcryptjs dependency for notification unit tests#8930
nishtha-agarwal-211 wants to merge 1 commit into
JhaSourav07:mainfrom
nishtha-agarwal-211:fix/bcryptjs-import-resolution

Conversation

@nishtha-agarwal-211

Copy link
Copy Markdown
Contributor

Description

Fixes #8920

Executing npm run test failed 6 unit test suites because Vitest could not resolve the bcryptjs import used in lib/notification-management-token.ts. This PR synchronizes package-lock.json so that bcryptjs dependencies are properly resolved, allowing all 120 test suites (857 tests) to pass cleanly.

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A (Dependency resolution and unit test fix)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

Copilot AI lite review requested due to automatic review settings August 6, 2026 10:08
@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@nishtha-agarwal-211 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@retenta-bot

retenta-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

This pull request addresses a critical dependency issue that was causing unit tests to fail. By resolving the bcryptjs import, it ensures that all tests can run successfully, which is essential for maintaining code quality. This is similar to past decisions where we focused on improving test reliability, such as adding tests for timezone normalization and calendar boundary handling. Thank you for your contribution, and I look forward to your updates!

@retenta-bot retenta-bot Bot changed the title fix(deps): resolve bcryptjs dependency in package-lock for notification unit tests fix(deps): resolve bcryptjs dependency for notification unit tests Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 4939.27 KB 4939.27 KB 0 B
Total CSS 348.46 KB 348.46 KB 0 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Fix bcryptjs import resolution failure in Notification API unit tests

2 participants