Fix: Resolve 4 Bugs in Commitpulse - #8928
Conversation
|
Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request effectively resolves several bugs in the Commitpulse codebase, including improvements to floating-point handling and promise rejection management. Similar past decisions have focused on ensuring robust error handling and proper data parsing, which aligns with the rationale behind these changes. Thank you for your contributions, and I look forward to your updates! |
|
👋 Hey @saurabhhhcodes! Thanks for your contribution! 🎉 Unfortunately, this PR has been automatically closed because it is not linked to any open issue. To resolve this, please do the following:
We look forward to reviewing your PR once an issue is linked! 🚀 |
Description
This PR fixes real bugs found in the codebase:
Number.EPSILONtoMath.round: prevents floating-point drift (e.g.1.005 * 100rounding to 100 instead of 101).parseInt: without10, strings like'0x1F'or'08'parse in unintended bases.return undefined: barereturnconveys the same intent without the redundant literal.Promise.all: an unhandled rejection in any input promise previously crashed silently.Type of Change
How Has This Been Tested?
Checklist
Related Issue
Ref: #8924