Skip to content

fix: resolve multiple bugs in commitpulse #8901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saurabhhhcodes wants to merge 1 commit into from
Closed

fix: resolve multiple bugs in commitpulse #8901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/achievements/AchievementsClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ export function UnlockCelebration({
);
if (!focusable || focusable.length === 0) return;
const first = focusable[0];
const last = focusable[focusable.length - 1];
const last = focusable.at(-1);
if (event.shiftKey && document.activeElement === first) {
event.preventDefault();
last.focus();
Expand Down
2 changes: 1 addition & 1 deletion app/api/streak/live/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export async function GET(request: Request) {
let interval = 30; // default 30s
if (intervalParam) {
const parsed = parseInt(intervalParam, 10);
if (!isNaN(parsed)) {
if (!Number.isNaN(parsed)) {
interval = Math.max(30, Math.min(parsed, 300));
}
}
Expand Down
2 changes: 1 addition & 1 deletion components/AdvancedColorPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ export default function AdvancedColorPicker({
{hexError && (
<p className="-mt-1.5 text-[10px] text-red-400 dark:text-red-500">{hexError}</p>
)}
{eyedropperSupported === false && (
{eyedropperSupported ! && (
<p className="-mt-1.5 text-[10px] text-amber-500 dark:text-amber-400">
Eyedropper not supported in this browser
</p>
Expand Down
Loading