fix: resolve multiple bugs in commitpulse - #8891
Conversation
|
Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request effectively resolves multiple bugs in the commitpulse codebase, similar to previous efforts that focused on improving sorting behavior and parsing consistency. The changes made here, such as fixing the default sort and simplifying empty-string validation, align well with our ongoing efforts to enhance code reliability. Thank you for your contributions, and keep up the great work! |
|
👋 Hey @saurabhhhcodes! Thanks for your contribution! 🎉 Unfortunately, this PR has been automatically closed because it is not linked to any open issue. To resolve this, please do the following:
We look forward to reviewing your PR once an issue is linked! 🚀 |
Description
This PR fixes real bugs found in the codebase:
.sort()coerces elements to strings, so[10, 9, 2]sorts as[10, 2, 9]; numeric comparator sorts correctly.trim()to''misses whitespace-only input;.trim().length === 0is explicit.parseInt: without10, strings like'0x1F'or'08'parse in unintended bases.return undefined: barereturnconveys the same intent without the redundant literal.Type of Change
How Has This Been Tested?
Checklist
Related Issue
Ref: #8889