Enhance toBooleanFlag Function to Support 'yes' and 'on' Inputs - #8882
Open
tmdeveloper007 wants to merge 1 commit into
Open
Enhance toBooleanFlag Function to Support 'yes' and 'on' Inputs#8882tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
|
This pull request extends the |
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod007
approved these changes
Aug 6, 2026
Aamod007
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this update! Adding support for 'yes' and 'on' in \ oBooleanFlag\ within \lib/validations.ts\ is a nice quality of life improvement. The use of .toLowerCase()\ to ensure case-insensitive matching is spot on, and checking !val\ first protects against errors. Looks solid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Extended
toBooleanFlagto recognize 'yes' and 'on' (case-insensitive) as valid true values in addition to 'true' and '1'.Changes Made
lib/validations.ts: Added 'yes' and 'on' totoBooleanFlagwith case-insensitive matchingImpact it Made
Closes #8850
Note: Please assign this PR to the
tmdeveloper007account.