Fix: Handle Undefined Window in getOrigin to Prevent SSR Errors - #8878
Open
tmdeveloper007 wants to merge 1 commit into
Open
Fix: Handle Undefined Window in getOrigin to Prevent SSR Errors#8878tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
|
This pull request addresses the issue of SSR errors by ensuring that the |
Aamod007
approved these changes
Aug 6, 2026
Aamod007
left a comment
Collaborator
There was a problem hiding this comment.
Great fix for SSR compatibility! Creating a dedicated \�rowserOrigin\ variable with strict checks (\ ypeof window !== 'undefined' && window != null) in \utils/urls.ts\ makes the \getOrigin\ function much safer for server-side environments like Next.js. The logic is clean and easy to follow. Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Refactored
getOriginto use an explicit guard for browser context. Thewindow.location.originaccess is now isolated with explicittypeof window !== 'undefined'andwindow != nullchecks.Changes Made
utils/urls.ts: RefactoredgetOriginwith explicit browser context guardImpact it Made
Closes #8846
Note: Please assign this PR to the
tmdeveloper007account.