fix: resolve multiple bugs in commitpulse - #8765
Conversation
|
Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request effectively resolves multiple bugs in the commitpulse codebase, similar to previous validated decisions that focused on enhancing code quality and preventing silent crashes from unhandled promise rejections. The changes made here align well with our ongoing efforts to maintain robust and reliable code. Thank you for your contributions! |
|
👋 Hey @saurabhhhcodes! Thanks for your contribution! 🎉 Unfortunately, this PR has been automatically closed because it is not linked to any open issue. To resolve this, please do the following:
We look forward to reviewing your PR once an issue is linked! 🚀 |
Description
This PR fixes real bugs found in the codebase:
Promise.all: an unhandled rejection in any input promise previously crashed silently.trim()to''misses whitespace-only input;.trim().length === 0is explicit.parseInt: without10, strings like'0x1F'or'08'parse in unintended bases..sort()coerces elements to strings, so[10, 9, 2]sorts as[10, 2, 9]; numeric comparator sorts correctly.Type of Change
How Has This Been Tested?
Checklist
Related Issue
Ref: #8762