fix: resolve multiple bugs in commitpulse - #8764
Conversation
|
Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request effectively resolves multiple bugs, enhancing the robustness of the commitpulse codebase. It aligns with previous decisions made regarding bug fixes, particularly in handling NaN values and promise rejections to prevent silent crashes. Thank you for your contributions, and I look forward to seeing this merged! |
|
👋 Hey @saurabhhhcodes! Thanks for your contribution! 🎉 Unfortunately, this PR has been automatically closed because it is not linked to any open issue. To resolve this, please do the following:
We look forward to reviewing your PR once an issue is linked! 🚀 |
Description
This PR fixes real bugs found in the codebase:
isNaNwithNumber.isNaN: the global version coerces its argument, soisNaN('1')returns false whileNumber.isNaNis strict.Promise.all: an unhandled rejection in any input promise previously crashed silently.return undefined: barereturnconveys the same intent without the redundant literal.Promise.all: an unhandled rejection in any input promise previously crashed silently.Type of Change
How Has This Been Tested?
Checklist
Related Issue
Ref: #8762