Skip to content

Fix: Make Authorization Header Check Case-Insensitive in verifyReviewAdmin - #8750

Merged
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
tmdeveloper007:fix/8677-case-insensitive-auth-header
Aug 6, 2026
Merged

Fix: Make Authorization Header Check Case-Insensitive in verifyReviewAdmin#8750
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
tmdeveloper007:fix/8677-case-insensitive-auth-header

Conversation

@tmdeveloper007

Copy link
Copy Markdown
Contributor

Description

Made the Authorization header comparison case-insensitive in lib/review-admin-auth.ts.

Pillar

  • Other (Bug fix, refactoring, docs)

Checklist

  • I have read the CONTRIBUTING.md file.
  • My commits follow the Conventional Commits format.

Note

Please assign this PR to the tmdeveloper007 account.

Closes #8677

@retenta-bot

retenta-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

This pull request addresses a critical bug by making the Authorization header check case-insensitive, which is essential for proper authentication. This change has been validated in past decisions, ensuring that clients with different casing can authenticate correctly without causing runtime errors. Thank you for your contribution, and please let me know if you need any further assistance!

@retenta-bot retenta-bot Bot changed the title fix : make Authorization header check case-insensitive in verifyReviewAdmin Fix: Make Authorization Header Check Case-Insensitive in verifyReviewAdmin Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 4939.27 KB 4939.27 KB 0 B
Total CSS 348.46 KB 348.46 KB 0 B

@Aamod007 Aamod007 added level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:bug Something isn't working as expected mentor:Aamod007 labels Aug 6, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great attention to detail. HTTP headers are technically case-insensitive, so calling .toLowerCase()\ on both the incoming authorization header and the expected 'Bearer' string in \lib/review-admin-auth.ts\ ensures maximum compatibility with different clients and proxies. Thanks for making this robust!

@JhaSourav07 JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Aug 6, 2026
@JhaSourav07
JhaSourav07 merged commit 209b522 into JhaSourav07:main Aug 6, 2026
15 of 16 checks passed
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🎉 Congratulations @tmdeveloper007! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix : make Authorization header check case-insensitive in verifyReviewAdmin

3 participants