Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/components/LandingPageClient.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ export default function LandingPageClient() {

const [username, setUsername] = useState('');
const [instantUsername, setInstantUsername] = useState('');
const [generationKey, setGenerationKey] = useState<number>(0);
const [copied, setCopied] = useState(false);

const [badgeResult, setBadgeResult] = useState<{
Expand Down Expand Up @@ -373,7 +374,9 @@ export default function LandingPageClient() {
latestPreviewUsernameRef.current = previewUsername;
}, [previewUsername]);

const badgeUrl = `/api/streak?user=${encodeURIComponent(previewUsername)}`;
const badgeUrl = `/api/streak?user=${encodeURIComponent(previewUsername)}${
generationKey ? `&t=${generationKey}` : ''
}`;
const siteUrl = (process.env.NEXT_PUBLIC_SITE_URL ?? 'https://commitpulse.vercel.app').replace(
/\/$/,
''
Expand Down Expand Up @@ -581,13 +584,15 @@ export default function LandingPageClient() {
setUsername(name);
setInstantUsername(name);
setBadgeResult(null);
setGenerationKey((prev) => prev + 1);
};

const handleGenerate = (e: React.FormEvent) => {
e.preventDefault();
if (trimmedUsername.length > 0 && trimmedUsername !== previewUsername) {
if (trimmedUsername.length > 0) {
setInstantUsername(trimmedUsername);
setBadgeResult(null);
setGenerationKey((prev) => prev + 1);
trackUser(trimmedUsername);
addSearch(trimmedUsername);
}
Expand Down
64 changes: 64 additions & 0 deletions app/page.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -217,4 +217,68 @@ describe('LandingPage', () => {
expect(global.fetch).toHaveBeenCalled();
});
});

it('re-triggers badge generation and resolves loading state on subsequent clicks', async () => {
vi.spyOn(global, 'fetch').mockImplementation((url) => {
if (typeof url === 'string' && url.includes('/api/user-details')) {
return Promise.resolve({
ok: true,
json: () =>
Promise.resolve({
exists: true,
login: 'octocat',
name: 'The Octocat',
avatar_url: 'https://github.com/octocat.png',
public_repos: 10,
stats: { currentStreak: 5, longestStreak: 12, totalContributions: 150 },
}),
} as Response);
}
return Promise.resolve({ ok: true, text: () => Promise.resolve('<svg></svg>') } as Response);
});

render(<LandingPage />);

const input = screen.getByPlaceholderText('Enter GitHub Username') as HTMLInputElement;

fireEvent.change(input, {
target: { value: 'octocat' },
});

const generateButton = screen.getByRole('button', {
name: /Generate Badge/i,
});

// 1st click
await act(async () => {
fireEvent.click(generateButton);
});

let badgeImg = screen.getByTestId('badge-img') as HTMLImageElement;
expect(badgeImg).toBeInTheDocument();
const initialSrc = badgeImg.src;
expect(initialSrc).toContain('/api/streak?user=octocat');

// Simulate initial onLoad
await act(async () => {
fireEvent.load(badgeImg);
});

// 2nd click with same username to re-trigger generation
await act(async () => {
fireEvent.click(generateButton);
});

badgeImg = screen.getByTestId('badge-img') as HTMLImageElement;
const retriggeredSrc = badgeImg.src;
expect(retriggeredSrc).toContain('/api/streak?user=octocat&t=');

// Simulate second onLoad
await act(async () => {
fireEvent.load(badgeImg);
});

// Verify SVG export buttons appear after loaded
expect(screen.getByRole('button', { name: /Download SVG/i })).toBeInTheDocument();
});
});
Loading