Skip to content

Fix MaxMind DB Reader stub namespaces - #1912

Open
Michał Mleczko (mleczakm) wants to merge 1 commit into
JetBrains:masterfrom
mleczakm:patch-1
Open

Fix MaxMind DB Reader stub namespaces#1912
Michał Mleczko (mleczakm) wants to merge 1 commit into
JetBrains:masterfrom
mleczakm:patch-1

Conversation

@mleczakm

Copy link
Copy Markdown

Summary

  • Correct InvalidDatabaseException and Metadata stubs to MaxMind\Db\Reader\* (matching maxmind-db/reader v1.13.1 and app imports)
  • Align Reader docblocks with upstream; add missing Metadata::__construct

Test plan

  • Confirm PHPStan/IDE resolves MaxMind\Db\Reader\InvalidDatabaseException from the stub
  • Smoke-check GeoIP lookup path still type-checks against Reader + InvalidDatabaseException

@isfedorov

Copy link
Copy Markdown
Contributor

Michał Mleczko (@mleczakm) Could you please update stubs map with command php tests/Framework/Tools/generate-stubs-map.php and commit result map as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants