You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR normalises the links to php.net as a few variants live within the stubs.
At least we should move towards https not depend on secure.php.net. So if this change is too much, we can get rid of the second commit.
Please see commits 1 by 1:
Commit 1: replaces secure.php.net with www.php.net
LC_ALL=C find . -type f -exec sed -i '''s/secure\.php\.net/www.php.net/g' {} +
Jordi Kroon (@jordikroon) That's a good point, but could you please clarify, what is a benefit of normalizing links to //www.php.net instead of //php.net (other than avoiding 301 redirect)? It's longer form and amount of required changes is huge (stubs have ~1300 occurrences of www.php.net while ~8800 of php.net). So I agree that links should be normalized, but I'd suggest to do it in a vice versa way. All existing www.php.net and secure.php.net convert to //php.net. Also please update related stubs check to verify that new added links are aligned with this rule (see PhpDocLinksCheck::checkLinks) and unit tests that will test this new change in PhpDocLinksCheck (see PhpDocLinksCheckTest). Oh, and please pay attention to https://github.com/JetBrains/phpstorm-stubs/blob/master/CONTRIBUTING.md#cache-files and avoid committing those Reflection*.json files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR normalises the links to php.net as a few variants live within the stubs.
At least we should move towards https not depend on secure.php.net. So if this change is too much, we can get rid of the second commit.
Please see commits 1 by 1:
Commit 1: replaces secure.php.net with www.php.net
Commit 2: replaces https://php.net with https://www.php.net
Commit 3: replaces http://php.net with https://www.php.net
Commit 4: fixes tests, intentionally using http:// here.