Repository navigation
Use requests for TinyTeX HTTPS downloads - #51
Open
sakshamgoyal-01 wants to merge 3 commits into
Open
sakshamgoyal-01 wants to merge 3 commits into
sakshamgoyal-01 wants to merge 3 commits into
Conversation
urllib against uv/standalone CPython fails TLS verification because it does not use certifi. requests does, so GitHub downloads work in those environments.
Pin requests to certifi's CA bundle and reject untrusted server certificates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50
Summary
urllib.request.urlopenfails TLS verification on uv/standalone CPython (typical in Docker) because that interpreter does not use certifi. Downloads then raiseSSLCertVerificationError: unable to get local issuer certificate.This switches GitHub fetches in
download_tinytex()torequests, which verifies with certifi.Changes
requests>=2.32.0as a runtime dependency.urlopenwithrequests.get(streamed for the asset download).RuntimeErrorbehavior.Tests
uv run pytest -vv tests/test_tinytex_download.py -k "not successful_download"