Confirmation avant perte de graphe non sauvegardé à l'ouverture - #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback traité
3d77c311-7857-4543-aa68-6efd214e94ef— Confirmation avant perte de graphe non sauvegardéAnalyse
Le rafraîchissement de page était déjà couvert par le handler
beforeunloadexistant (
Initialize.tsx), tout comme le bouton retour. En revanche,l'action « Workspace > Ouvrir » du menu principal (
Header.tsx) ouvraitdirectement la modale de sélection de fichier sans avertir que le graphe en
cours, s'il avait des modifications non enregistrées, allait être remplacé.
Changement
Ajoute une confirmation (même message que les gardes existantes, back-button
et beforeunload) avant d'ouvrir la modale « Ouvrir un graphe » lorsque le
graphe courant a des modifications non sauvegardées (
isDirty).Effort classé Faible (7 lignes, un seul fichier, aucun impact
architectural) — implémenté et mergé directement selon les garde-fous en
vigueur.