fix indexing / sorting for initializing gradient with no warm start#146
Open
jonathan-taylor wants to merge 1 commit into
Open
fix indexing / sorting for initializing gradient with no warm start#146jonathan-taylor wants to merge 1 commit into
jonathan-taylor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #144
But it feels like an even simpler fix is to just set
grad=np.zeros(p, dtype=dtype)because that is what is going to happen anyways. Or is there a reason to callA.mulat this point https://github.com/JamesYang007/adelie/pull/146/files#diff-2d0d2cfb4367fb01b4097db4a37b931116ceedf4bc91d5048c8989eda0a0de86R296