JsonTextReader loses precision for double/decimal number tokens — no way to access raw source text - #3108
Open
sachinkale246 wants to merge 1 commit into
Open
JsonTextReader loses precision for double/decimal number tokens — no way to access raw source text#3108sachinkale246 wants to merge 1 commit into
sachinkale246 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing JSON into a JToken, there is no way to preserve exact numeric precision for floating-point values that are representable by double or decimal but not both:
JSON and code related to the issue
[1.7976931348623157E+308, 1.23456789012345678901234567890]
// double.MaxValue overflows decimal → throws with FloatParseHandling.Decimal
// high-precision decimal loses digits with FloatParseHandling.Double (default)
var reader = new JsonTextReader(new StringReader(json));
reader.FloatParseHandling = FloatParseHandling.Double; // or Decimal — neither handles both
var token = JToken.ReadFrom(reader);
Suggested fix (with PR)
Two additions to JsonTextReader: