Reduce allocations in ToMultidimensionalArray - #3093
Open
alexzzzs wants to merge 1 commit into
Open
Conversation
- Replaced O(N) intermediate array allocations in CopyFromJaggedToMultidimensionalArray with a single reusable buffer. - Updated JaggedArrayGetValue to support partial buffer traversal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizes the
ToMultidimensionalArraymethod to reduce memory allocations when deserializing multidimensional arrays.The Issue
The previous implementation of
CopyFromJaggedToMultidimensionalArraycreated a newint[]array at every step of the recursion to store indices. For large multidimensional arrays (e.g., 3D grids), this resulted in O(N) intermediate array allocations, creating unnecessary GC pressure.The Fix
int[]buffer allocated once at the entry point.JaggedArrayGetValueto accept a length parameter, allowing it to read from the shared buffer without needing a trimmed copy.