module_cmd: allow loading already-loaded modules - #578
Merged
climbfuji merged 1 commit intoAug 18, 2026
Conversation
mathomp4
marked this pull request as ready for review
August 18, 2026 16:32
climbfuji
approved these changes
Aug 18, 2026
climbfuji
left a comment
climbfuji
left a comment
Collaborator
There was a problem hiding this comment.
Thank you very much, this is a life saver!
AlexanderRichert-NOAA
approved these changes
Aug 18, 2026
github-project-automation
Bot
moved this from In Progress
to Done
in spack-stack-2.2.x (2026 Q?)
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport Spack upstream PR spack#52752 to
spack-stack-dev.load_module()now treats an already-loaded module as a successful no-op.Motivation
Module systems such as Lmod successfully accept a repeated
module load, but leaveLOADEDMODULESunchanged. Previously, Spack interpreted that unchanged value as a module-load failure. This occurs when an external compiler and MPI specification share prerequisite modules.The change avoids false
ModuleLoadErrorfailures while preserving the existing validation for genuinely unsuccessful module loads.Validation
This exact change, including the regression test, was merged upstream in spack#52752.