Fix Mac Catalyst refresh control regression with process-level idiom check - #63
Merged
Merged
Conversation
behavioralStyle on UIView requires the view to be in a window to resolve correctly. configureIfNeeded() fires from onRefresh didSet before the collection view is in a hierarchy, so behavioralStyle returns .pad instead of .mac, bypassing the guard and crashing. Switch to UIDevice.current.userInterfaceIdiom which is process-level and returns .mac for Mac Catalyst Mac idiom regardless of view state. Closes #62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
behavioralStyleguard from Fix Mac Catalyst crash when onRefresh is set #60 doesn't work becauseUIView.behavioralStylerequires the view to be in a window hierarchy to resolve correctly —configureIfNeeded()fires fromonRefresh'sdidSetbefore the collection view has a window, sobehavioralStylereturns.padinstead of.mac, bypassing the guardUIDevice.current.userInterfaceIdiom != .mac, which is a process-level property that correctly returns.macfor Mac Catalyst Mac idiom regardless of view hierarchy stateuserInterfaceIdiom == .pad) continue to get pull-to-refreshCloses #62
Test plan
make buildsucceedsmake test— all 301 tests passmake lintpassesonRefreshset — no crash, refresh silently skipped