Use heuristic to determine custom nether dimension types - #3276
Open
TehBrian wants to merge 1 commit into
Open
Conversation
TehBrian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on the work of #2853 and #2955, this PR adjusts
getCurrentDimensionto use a heuristic to determine whether the player is in a nether-like custom dimension type. This allows shaderpacks to apply effects appropriate for nether-like dimensions.Since skybox
noneis used for custom worlds in addition to the nether, the heuristic additionally checks that the cardinal lighting type isnether, which explicitly indicates that the dimension type intends to follow the styling of the standard nether.Before
Using Complementary Reimagined r5.8.1.
After
Using Complementary Reimagined r5.8.1.