Skip to content

Fix custom dimension skybox (1.21.11 regression) #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IMS212 merged 1 commit into from
Mar 4, 2026
+7 −7
Merged

Fix custom dimension skybox (1.21.11 regression) #2955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions common/src/main/java/net/irisshaders/iris/Iris.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
import net.minecraft.network.chat.Component;
import net.minecraft.network.chat.HoverEvent;
import net.minecraft.resources.Identifier;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.dimension.DimensionType;
import org.jetbrains.annotations.NotNull;
import org.lwjgl.glfw.GLFW;
import org.lwjgl.opengl.ARBParallelShaderCompile;
Expand Down Expand Up @@ -623,19 +623,19 @@ public static NamespacedId getCurrentDimension() {
return dimensionId;
}

// Check if the dimension type of the current level has custom effects set (end sky or nether).
// This is minecraft:overworld by default, but can also be minecraft:the_nether or minecraft:the_end.
// Check if the dimension type of the current level has a custom skybox set (end sky or overworld).
// This is OVERWORLD by default, but can also be END or NONE.
// The appropriate shader for the dimension should be used by default in order to prevent buggy results.
// More information at https://minecraft.wiki/w/Dimension_type
// https://github.com/IrisShaders/Iris/issues/2200
Identifier effects = level.dimension().identifier();
DimensionType.Skybox skybox = level.dimensionType().skybox();

if (Level.END.identifier().equals(effects)) {
if (skybox == DimensionType.Skybox.END) {
return DimensionId.END;
}

if (Level.NETHER.identifier().equals(effects)) {
return DimensionId.NETHER;
if (skybox == DimensionType.Skybox.OVERWORLD) {
return DimensionId.OVERWORLD;
}

return dimensionId;
Expand Down
Loading