Skip to content

[Feature] Support transactional sandbox dependency groups - #2032

Open
matrix72c wants to merge 3 commits into
InternLM:mainfrom
matrix72c:feat/sandbox-pool-dependencies
Open

[Feature] Support transactional sandbox dependency groups#2032
matrix72c wants to merge 3 commits into
InternLM:mainfrom
matrix72c:feat/sandbox-pool-dependencies

Conversation

@matrix72c

Copy link
Copy Markdown
Contributor

Summary

  • extend SandboxSpec with one-level dependency groups and an optional provisioner
  • create and health-check dependencies before the primary sandbox
  • roll back the whole group in reverse order when creation, health checks, or provisioning fail
  • retry group acquisition transactionally and clean up returned members on cancellation
  • keep the public pool API backward-compatible by exposing only the primary client
  • apply sandbox creation rate limiting to every physical sandbox

Tests

  • pytest -q tests/rl/test_sandbox_pool.py: 8 passed
  • ruff check: passed
  • ruff format --check: passed
  • git diff --check: passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant