Skip to content

refactor filters and movers - #796

Merged
zyxkad merged 8 commits into
IntelligenceModding:dev/1.21.1from
zyxkad:inventory-utils-refactor
Nov 22, 2025
Merged

zyxkad merged 8 commits into
IntelligenceModding:dev/1.21.1from
zyxkad:inventory-utils-refactor

Conversation

@zyxkad

@zyxkad zyxkad commented Nov 19, 2025 •

Copy link
Copy Markdown
Collaborator

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    Should not

  • Other information:
    Fluid & chemical filter now will accept amount instead of count. The support of count field should be removed in 0.8.

@github-actions

github-actions Bot commented Nov 19, 2025 •

Copy link
Copy Markdown
Contributor

Build Preview

badge

You can find files attached to the below linked Workflow Run URL (Logs).

Name Link
Commit 362b84d
Logs https://github.com/IntelligenceModding/AdvancedPeripherals/actions/runs/19600437956
Jar Files AdvancedPeripherals PR 796
Expires At 2026-02-20T19:52:08Z

fix fill implemention returns remaining instead of inserted
@zyxkad
zyxkad marked this pull request as ready for review November 19, 2025 20:16
@zyxkad
zyxkad requested a review from SirEndii November 19, 2025 20:16

@SirEndii SirEndii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Free to merge when you don't have anything to add.

@SirEndii SirEndii mentioned this pull request Nov 19, 2025
1 of 2 tasks
zyxkad and others added 3 commits November 19, 2025 14:23
@zyxkad
zyxkad marked this pull request as draft November 21, 2025 02:53
do not throw exception when slot is out of range
@zyxkad
zyxkad marked this pull request as ready for review November 22, 2025 19:52
@zyxkad
zyxkad merged commit 25de146 into IntelligenceModding:dev/1.21.1 Nov 22, 2025
3 checks passed
@zyxkad
zyxkad deleted the inventory-utils-refactor branch November 22, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants