Repository navigation
feat: Remove legacy notification permission request from MainActivity - #285
Merged
Merged
Conversation
LunarX
changed the title
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow removal matches the existing onboarding permission flow and receiver guard, with no unresolved issues identified.
No open issues 🎉
What changed in this PR
Removes the legacy notification permission prompt from MainActivity, leaving onboarding responsible for requesting permission.
Changes:
- Removes the permission launcher, fresh-start request, helper, and unused imports.
- Updates app documentation to describe onboarding ownership and the existing notification guard in
AlarmReceiver.
| File | Description |
|---|---|
app/src/main/java/com/infomaniak/calendar/MainActivity.kt |
Removes the activity-level notification permission request. |
app/AGENTS.md |
Documents the onboarding-only permission flow. |
Review effort: Balanced
LunarX
force-pushed
the
remove-legacy-notification-permission
branch
from
October 27, 2026 14:36
e6f3fe4 to
f98353f
Compare
LunarX
enabled auto-merge
October 27, 2026 14:36
NicolasBourdin88
approved these changes
Oct 27, 2026
The onboarding's notifications step now requests it; AlarmReceiver already skips posting when notifications are disabled. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
LunarX
force-pushed
the
remove-legacy-notification-permission
branch
from
October 27, 2026 15:34
f98353f to
f57901b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The onboarding's notifications step now requests it; AlarmReceiver already skips posting when notifications are disabled.