Repository navigation
feat: Animate dividers between detail and edit screens while waiting for the new design - #282
Merged
Merged
Conversation
LunarX
force-pushed
the
animate-dividers-while-waiting-for-new-design
branch
from
October 28, 2026 10:15
d3a5366 to
22f4a9e
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Device validation is needed for empty-first-section transitions because Section composes but does not measure or place the shared-element divider, while the edit form always renders its counterpart.
No open issues 🎉
What changed in this PR
Adds shared-element animations for section dividers between the event detail and edit screens, as an interim improvement ahead of the new design.
Changes:
- Defines four shared-element identifiers for section dividers.
- Assigns divider identifiers to detail and form sections.
- Applies the shared-element modifier to dividers in the reusable
Sectioncomponent.
| File | Description |
|---|---|
CalendarComponents/EventDetail/src/main/kotlin/com/infomaniak/calendar/components/eventdetail/modifier/EventSharedBounds.kt |
Adds four divider identifiers. |
CalendarComponents/EventDetail/src/main/kotlin/com/infomaniak/calendar/components/eventdetail/form/EventForm.kt |
Assigns matching identifiers to form dividers. |
CalendarComponents/EventDetail/src/main/kotlin/com/infomaniak/calendar/components/eventdetail/detail/EventDetail.kt |
Assigns identifiers to detail dividers. |
CalendarComponents/EventDetail/src/main/kotlin/com/infomaniak/calendar/components/eventdetail/component/Section.kt |
Accepts a shared-element identifier and applies it to the divider. |
Review effort: Balanced
LunarX
force-pushed
the
animate-dividers-while-waiting-for-new-design
branch
from
October 28, 2026 10:36
22f4a9e to
71c496a
Compare
NicolasBourdin88
approved these changes
Oct 28, 2026
LunarX
force-pushed
the
animate-dividers-while-waiting-for-new-design
branch
from
October 28, 2026 10:51
71c496a to
2f7102d
Compare
LunarX
force-pushed
the
animate-dividers-while-waiting-for-new-design
branch
3 times, most recently
from
October 29, 2026 08:54
644bff4 to
efe0333
Compare
LunarX
force-pushed
the
animate-dividers-while-waiting-for-new-design
branch
2 times, most recently
from
October 29, 2026 15:29
dce3b9d to
fd18eb8
Compare
…for the new design
LunarX
force-pushed
the
animate-dividers-while-waiting-for-new-design
branch
from
October 30, 2026 07:08
fd18eb8 to
9fcc748
Compare
|
This PR/issue depends on:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #281