Repository navigation
feat: Add the reminder offset dialog to the event form - #272
Open
NicolasBourdin88 wants to merge 1 commit into
Open
NicolasBourdin88 wants to merge 1 commit into
NicolasBourdin88 wants to merge 1 commit into
Conversation
NicolasBourdin88
force-pushed
the
reminder-dialog
branch
from
October 23, 2026 13:35
9a41e84 to
4a9c9fa
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The dialog needs scrolling so lower reminder choices remain reachable in height-constrained windows.
1 open issue
What changed in this PR
Adds a reminder-offset dialog to the shared event form. Reminder persistence and the custom editor remain deferred.
Changes:
- Opens a dialog from the Add Reminder button with preset offsets, None, and Custom.
- Adds localized None and Custom labels across 13 resource files.
| File | Description |
|---|---|
| CalendarComponents/Resources/src/main/res/values/strings.xml | Adds default English labels. |
| CalendarComponents/Resources/src/main/res/values-sv/strings.xml | Adds Swedish labels. |
| CalendarComponents/Resources/src/main/res/values-pt/strings.xml | Adds Portuguese labels. |
| CalendarComponents/Resources/src/main/res/values-pl/strings.xml | Adds Polish labels. |
| CalendarComponents/Resources/src/main/res/values-nl/strings.xml | Adds Dutch labels. |
| CalendarComponents/Resources/src/main/res/values-nb/strings.xml | Adds Norwegian Bokmål labels. |
| CalendarComponents/Resources/src/main/res/values-it/strings.xml | Adds Italian labels. |
| CalendarComponents/Resources/src/main/res/values-fr/strings.xml | Adds French labels. |
| CalendarComponents/Resources/src/main/res/values-fi/strings.xml | Adds Finnish labels. |
| CalendarComponents/Resources/src/main/res/values-es/strings.xml | Adds Spanish labels. |
| CalendarComponents/Resources/src/main/res/values-el/strings.xml | Adds Greek labels. |
| CalendarComponents/Resources/src/main/res/values-de/strings.xml | Adds German labels. |
| CalendarComponents/Resources/src/main/res/values-da/strings.xml | Adds Danish labels. |
| CalendarComponents/EventDetail/src/main/kotlin/com/infomaniak/calendar/components/eventdetail/form/EventForm.kt | Manages dialog visibility from the reminder button. |
| CalendarComponents/EventDetail/src/main/kotlin/com/infomaniak/calendar/components/eventdetail/form/component/ReminderOffsetDialog.kt | Introduces preset choices and selection callbacks. |
Review effort: Balanced
NicolasBourdin88
force-pushed
the
reminder-dialog
branch
from
October 26, 2026 13:44
4a9c9fa to
909cb71
Compare
NicolasBourdin88
force-pushed
the
reminder-dialog
branch
2 times, most recently
from
October 26, 2026 14:40
1858f16 to
c155597
Compare
NicolasBourdin88
force-pushed
the
reminder-dialog
branch
2 times, most recently
from
October 26, 2026 14:56
2e9a136 to
2948249
Compare
NicolasBourdin88
force-pushed
the
reminder-dialog
branch
from
October 28, 2026 09:54
2948249 to
3b5b1da
Compare
NicolasBourdin88
force-pushed
the
reminder-dialog
branch
from
October 29, 2026 08:42
3b5b1da to
ba94568
Compare
NicolasBourdin88
force-pushed
the
reminder-dialog
branch
from
October 29, 2026 13:33
ba94568 to
bc2afe4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.