Repository navigation
feat: Display human readable rrule in event detail - #246
Merged
Merged
Conversation
LunarX
force-pushed
the
simple-rrule-display
branch
from
October 15, 2026 07:55
08af52b to
fea49f3
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The dependency upgrade lacks its matching submodule update, and null recurrence descriptions leave an empty icon-only row.
2 open findings
What changed in this PR
Adds human-readable recurrence descriptions to event details using CalendarCore 0.15.0.
Changes:
- Adds asynchronous recurrence text rendering and preview examples.
- Connects event models to the localized recurrence formatter.
- Upgrades CalendarCore and removes the contacts settings provider.
| File | Description |
|---|---|
| gradle/libs.versions.toml | Upgrades CalendarCore to 0.15.0. |
| CalendarComponents/EventDetail/src/main/kotlin/com/infomaniak/calendar/components/eventdetail/models/EventDetailUi.kt | Adds a recurrence-text callback. |
| CalendarComponents/EventDetail/src/main/kotlin/com/infomaniak/calendar/components/eventdetail/detail/EventDetail.kt | Displays recurrence details. |
| CalendarComponents/EventDetail/src/main/kotlin/com/infomaniak/calendar/components/eventdetail/component/Recurrence.kt | Adds asynchronous recurrence rendering. |
| app/src/main/java/com/infomaniak/calendar/utils/EventExt.kt | Connects occurrences to the formatter. |
| app/src/main/java/com/infomaniak/calendar/ui/screen/eventDetail/detail/EventDetailScreen.kt | Updates preview recurrence data. |
| app/src/main/java/com/infomaniak/calendar/di/AppGraph.kt | Removes the contacts settings provider. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
sirambd
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump km p to 0.15.0 to be able to use the exposed methods for it