Skip to content

fix: attempt to improve v2 checkbox disabled state#7040

Merged
scott-ray-wilson merged 1 commit into
mainfrom
attempt-to-improve-v2-checkbox-disabled-state
Jun 26, 2026
Merged

fix: attempt to improve v2 checkbox disabled state#7040
scott-ray-wilson merged 1 commit into
mainfrom
attempt-to-improve-v2-checkbox-disabled-state

Conversation

@scott-ray-wilson

Copy link
Copy Markdown
Contributor

Context

Attempt to make the v2 checkbox disabled state more apparent

Screenshots

CleanShot 2026-06-25 at 16 13 59@2x

Steps to verify the change

👀

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Updated CLAUDE.md files (if needed)
  • Read the contributing guide

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-infisical-7040-attempt-to-improve-v2-checkbox-disabled-state

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR improves the visual appearance of the disabled state for the v2 Checkbox component by adding cursor-not-allowed and opacity-40, and darkens the default base background from bg-mineshaft-600 to bg-mineshaft-700.

  • Disabled state: replaces the old flat bg-bunker-400 override with opacity-40 for a more universally apparent "dimmed" look and adds the cursor-not-allowed cursor.
  • Base background: shifts from bg-mineshaft-600 to bg-mineshaft-700, providing a slightly higher-contrast default that better separates unchecked checkboxes from their surroundings.

Confidence Score: 4/5

Purely visual Tailwind class changes with no logic impact — safe to merge.

The change only touches CSS utility classes on a single presentational component. The one minor concern is that the previous disabled override explicitly neutralized the hover transition, but the new version omits this, leaving the base hover class active even when the checkbox is disabled.

No files require special attention beyond the hover behaviour noted in Checkbox.tsx.

Important Files Changed

Filename Overview
frontend/src/components/v2/Checkbox/Checkbox.tsx Tightens disabled state styling: adds cursor-not-allowed and opacity-40 instead of a flat background swap; also darkens the default base background from bg-mineshaft-600 to bg-mineshaft-700

Reviews (1): Last reviewed commit: "fix(?): attempt to improve v2 checkbox d..." | Re-trigger Greptile

Comment thread frontend/src/components/v2/Checkbox/Checkbox.tsx
Comment thread frontend/src/components/v2/Checkbox/Checkbox.tsx
@scott-ray-wilson scott-ray-wilson changed the title Attempt to improve v2 checkbox disabled state fix: attempt to improve v2 checkbox disabled state Jun 25, 2026
@scott-ray-wilson scott-ray-wilson merged commit c25d5ab into main Jun 26, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants