feat: improve response types from "any" to typed lease data responses#7033
Draft
varonix0 wants to merge 1 commit into
Draft
feat: improve response types from "any" to typed lease data responses#7033varonix0 wants to merge 1 commit into
varonix0 wants to merge 1 commit into
Conversation
|
💬 Discussion in Slack: #pr-review-infisical-7033-feat-improve-response-types-from-any-to-typed-lease-dat Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
DRAFT:
This PR aims to add better type safety for the leased data that we return. Historically, we've just been returning unknown, which in the documentation has been reflected as return type any. The user had no way to tell what data structure was going to be returned when they go and generate a lease, because it differs slightly between most of our dynamic secret lease types. This PR addresses that gap.
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).