Skip to content

fix(admin-signup): fix Continue button cutoff on desktop viewports (fixes #1411) #7028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codewithsupra wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(admin-signup): fix Continue button cutoff on desktop viewports (fixes #1411) #7028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/pages/admin/SignUpPage/SignUpPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,15 @@ export const SignUpPage = () => {
}

return (
<div className="flex max-h-screen min-h-screen flex-col justify-center overflow-y-auto bg-linear-to-tr from-mineshaft-600 via-mineshaft-800 to-bunker-700 px-6">
<div className="flex min-h-screen flex-col overflow-y-auto bg-linear-to-tr from-mineshaft-600 via-mineshaft-800 to-bunker-700 px-6">

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore a bounded scroll container

When the signup form is taller than the viewport (for example a short desktop window or browser zoom), this div no longer has a definite/max height, so overflow-y-auto does not create an internal scrollport. Since frontend/src/index.css sets html to overflow-hidden, the viewport/body cannot scroll either, leaving the lower part of the admin signup form unreachable in the same scenario this change is meant to fix. Keeping a viewport-bound height here (while avoiding justify-center) is needed for the page to scroll.

Useful? React with 👍 / 👎.

<Helmet>
<title>{t("common.head-title", { title: t("signup.title") })}</title>
<link rel="icon" href="/infisical.ico" />
<meta property="og:image" content="/images/message.png" />
<meta property="og:title" content={t("signup.og-title") ?? ""} />
<meta name="og:description" content={t("signup.og-description") ?? ""} />
</Helmet>
<div className="flex items-center justify-center">
<div className="my-auto flex items-center justify-center py-8">
<AnimatePresence mode="wait">
<motion.div
className="text-mineshaft-200"
Expand Down