Skip to content

fix: add missing POST method to Render env-group redeploy requests#7017

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1782334286-fix-render-env-group-redeploy
Open

fix: add missing POST method to Render env-group redeploy requests#7017
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1782334286-fix-render-env-group-redeploy

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Context

When a Render secret sync is configured with autoRedeployServices enabled and targets an Environment Group, the redeploy step silently no-ops.

In redeployService(), the EnvironmentGroup case iterates serviceLinks and calls /services/{id}/deploys — but without method: "POST" on the Axios config. Axios defaults to GET, which hits the list deploys endpoint (returns 200 with a deploy history array). The sync treats that 200 as success and marks the sync succeeded, but no deploy is actually triggered.

The Service case already had method: "POST" and worked correctly.

- request.request({ ...req, url: `/services/${link.id}/deploys`, data: {} })
+ request.request({ ...req, method: "POST", url: `/services/${link.id}/deploys`, data: {} })

Steps to verify the change

  1. Set up a Render secret sync targeting an Environment Group with autoRedeployServices enabled
  2. Change a secret in Infisical and trigger a sync
  3. Verify that all services linked to the env group are actually redeployed on Render (check Render dashboard → service → Events)

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

Link to Devin session: https://app.devin.ai/sessions/8863427fdaaf468fa2845c1097ea07a6

The redeployService function's EnvironmentGroup case was calling
/services/{id}/deploys without specifying method: 'POST'. Axios
defaults to GET when no method is given, which lists deploys instead
of triggering one. The Service case already had the correct method.

This caused auto-redeploy on env var changes to silently succeed
(200 from the list endpoint) without actually triggering a deploy.

Co-Authored-By: ryancab <ryancab@infisical.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a silent failure in the Render secret sync where redeploying services linked to an Environment Group was a no-op. Without method: "POST", Axios defaulted to GET on the /services/{id}/deploys endpoint, which returns the deploy history with a 200 status — so the sync appeared successful but no redeploy was triggered.

  • Adds method: "POST" to the EnvironmentGroup branch of redeployService(), making it consistent with the already-correct Service branch.

Confidence Score: 5/5

Safe to merge — single-line fix that aligns the EnvironmentGroup code path with the already-working Service path.

The change is a one-line addition of method: "POST" that brings the EnvironmentGroup deploy call in line with the Service deploy call. The root cause (Axios defaulting to GET when no method is specified) is well-understood and well-documented, and the fix matches the established pattern in the same function. No side effects, no new code paths, no schema or API contract changes.

No files require special attention.

Important Files Changed

Filename Overview
backend/src/services/secret-sync/render/render-sync-fns.ts Adds missing method: "POST" to the EnvironmentGroup deploy request, fixing a silent no-op where Axios defaulted to GET (list deploys) instead of triggering a new deployment.

Reviews (1): Last reviewed commit: "fix: add missing POST method to Render e..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants