fix: add missing POST method to Render env-group redeploy requests#7017
fix: add missing POST method to Render env-group redeploy requests#7017devin-ai-integration[bot] wants to merge 1 commit into
Conversation
The redeployService function's EnvironmentGroup case was calling
/services/{id}/deploys without specifying method: 'POST'. Axios
defaults to GET when no method is given, which lists deploys instead
of triggering one. The Service case already had the correct method.
This caused auto-redeploy on env var changes to silently succeed
(200 from the list endpoint) without actually triggering a deploy.
Co-Authored-By: ryancab <ryancab@infisical.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
| Filename | Overview |
|---|---|
| backend/src/services/secret-sync/render/render-sync-fns.ts | Adds missing method: "POST" to the EnvironmentGroup deploy request, fixing a silent no-op where Axios defaulted to GET (list deploys) instead of triggering a new deployment. |
Reviews (1): Last reviewed commit: "fix: add missing POST method to Render e..." | Re-trigger Greptile
Context
When a Render secret sync is configured with
autoRedeployServicesenabled and targets an Environment Group, the redeploy step silently no-ops.In
redeployService(), theEnvironmentGroupcase iteratesserviceLinksand calls/services/{id}/deploys— but withoutmethod: "POST"on the Axios config. Axios defaults toGET, which hits the list deploys endpoint (returns 200 with a deploy history array). The sync treats that 200 as success and marks the sync succeeded, but no deploy is actually triggered.The
Servicecase already hadmethod: "POST"and worked correctly.Steps to verify the change
autoRedeployServicesenabledType
Checklist
type(scope): short descriptionLink to Devin session: https://app.devin.ai/sessions/8863427fdaaf468fa2845c1097ea07a6