fix(api): add missing operationId to delete PKI Subscriber route#7001
Open
jaydeep-pipaliya wants to merge 1 commit into
Open
fix(api): add missing operationId to delete PKI Subscriber route#7001jaydeep-pipaliya wants to merge 1 commit into
jaydeep-pipaliya wants to merge 1 commit into
Conversation
Every other route in this router has an operationId in its schema block (getPkiSubscriber, createPkiSubscriber, updatePkiSubscriber, orderPkiSubscriberCertificate, etc). DELETE /:subscriberName was the only one without it, which means the OpenAPI spec ends up using an auto-generated name for that operation instead of a stable, predictable one. Same shape as the operationId fixes already merged elsewhere in the API.
Contributor
|
| Filename | Overview |
|---|---|
| backend/src/server/routes/v1/pki-subscriber-router.ts | Adds missing operationId: "deletePkiSubscriber" to the DELETE /:subscriberName route schema, making it consistent with all other routes in the file. |
Reviews (1): Last reviewed commit: "fix(api): add missing operationId to del..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DELETE /:subscriberName in pki-subscriber-router.ts is the only route in that router without an
operationIdin its schema block. Every other route in the file (getPkiSubscriber,createPkiSubscriber,updatePkiSubscriber,orderPkiSubscriberCertificate,issuePkiSubscriberCertificate,signPkiSubscriberCertificate,getPkiSubscriberLatestCertificateBundle,listPkiSubscriberCertificates) has one.Without an explicit
operationId, the OpenAPI spec ends up with an auto-generated name for the delete operation. Generated client SDKs and OpenAPI consumers will see a churn-prone name instead of a stable, predictabledeletePkiSubscriber.One-line fix.
Checklist