Skip to content

fix(api): add missing operationId to delete PKI Subscriber route#7001

Open
jaydeep-pipaliya wants to merge 1 commit into
Infisical:mainfrom
jaydeep-pipaliya:fix/pki-subscriber-delete-operation-id
Open

fix(api): add missing operationId to delete PKI Subscriber route#7001
jaydeep-pipaliya wants to merge 1 commit into
Infisical:mainfrom
jaydeep-pipaliya:fix/pki-subscriber-delete-operation-id

Conversation

@jaydeep-pipaliya

Copy link
Copy Markdown
Contributor

What

DELETE /:subscriberName in pki-subscriber-router.ts is the only route in that router without an operationId in its schema block. Every other route in the file (getPkiSubscriber, createPkiSubscriber, updatePkiSubscriber, orderPkiSubscriberCertificate, issuePkiSubscriberCertificate, signPkiSubscriberCertificate, getPkiSubscriberLatestCertificateBundle, listPkiSubscriberCertificates) has one.

Without an explicit operationId, the OpenAPI spec ends up with an auto-generated name for the delete operation. Generated client SDKs and OpenAPI consumers will see a churn-prone name instead of a stable, predictable deletePkiSubscriber.

One-line fix.

Checklist

  • I have read the contributing guide
  • I have added tests (schema-only addition)
  • The change is limited to the affected code path

Every other route in this router has an operationId in its schema block (getPkiSubscriber, createPkiSubscriber, updatePkiSubscriber, orderPkiSubscriberCertificate, etc). DELETE /:subscriberName was the only one without it, which means the OpenAPI spec ends up using an auto-generated name for that operation instead of a stable, predictable one. Same shape as the operationId fixes already merged elsewhere in the API.
@greptile-apps

greptile-apps Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a single missing operationId field to the DELETE PKI subscriber route schema, aligning it with every other route in the file which already has explicit operation IDs.

  • Adds operationId: "deletePkiSubscriber" to the DELETE /:subscriberName schema block, preventing auto-generated churn-prone names in the OpenAPI spec.
  • No logic changes — this is a schema metadata fix only with no runtime behavior impact.

Confidence Score: 5/5

Safe to merge — the change is a one-line schema metadata addition with no logic, runtime, or security impact.

The only change is adding operationId: "deletePkiSubscriber" to an OpenAPI schema block. It matches the exact pattern used by the eight other routes in the same file, introduces no new logic, and cannot affect request handling or data flow.

No files require special attention.

Important Files Changed

Filename Overview
backend/src/server/routes/v1/pki-subscriber-router.ts Adds missing operationId: "deletePkiSubscriber" to the DELETE /:subscriberName route schema, making it consistent with all other routes in the file.

Reviews (1): Last reviewed commit: "fix(api): add missing operationId to del..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant