Skip to content

Add confirm=true import gated by trusted caller (adb/shell-only) #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
djbclark wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add confirm=true import gated by trusted caller (adb/shell-only) #3073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52ba57f
Add deep-link actions for update check, settings, and headless exit
djbclark Jul 14, 2026
9fb7ac5
feat: mark obtainium:// intents from ADB/shell as trusted
djbclark Jul 14, 2026
72daf29
Add confirm=true import gated by trusted caller check
djbclark Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions android/app/src/main/kotlin/dev/imranr/obtainium/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ class MainActivity : FlutterActivity() {

override fun onCreate(savedInstanceState: Bundle?) {
intent?.let {
setIntent(transformShareIntent(it))
setIntent(markTrustedIfPrivileged(transformShareIntent(it)))
}
super.onCreate(savedInstanceState)
}

override fun onNewIntent(intent: Intent) {
val newIntent = transformShareIntent(intent)
val newIntent = markTrustedIfPrivileged(transformShareIntent(intent))
setIntent(newIntent)
try {
super.onNewIntent(newIntent)
Expand Down Expand Up @@ -100,6 +100,25 @@ class MainActivity : FlutterActivity() {
return uri.toString()
}

/**
* Marks obtainium:// intents from privileged callers (ADB shell, system)
* with confirmedBy=system so the Dart side can distinguish trusted
* launches from browser-based phishing links. A null referrer means
* the activity was launched by the ActivityManager directly (e.g.
* `adb shell am start`) — regular apps and browsers always set a
* non-null referrer.
*/
private fun markTrustedIfPrivileged(intent: Intent): Intent {
val uri = intent.data ?: return intent
if (uri.scheme != "obtainium") return intent
if (referrer != null) return intent

val builder = uri.buildUpon()
builder.appendQueryParameter("confirmedBy", "system")
intent.data = builder.build()
return intent
}

private fun transformShareIntent(intent: Intent): Intent {
if (intent.action == Intent.ACTION_SEND && intent.type?.startsWith("text/") == true) {
val sharedText = intent.getStringExtra(Intent.EXTRA_TEXT)
Expand Down
299 changes: 247 additions & 52 deletions lib/pages/home.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@ import 'package:obtainium/pages/apps.dart';
import 'package:obtainium/pages/settings.dart';
import 'package:obtainium/providers/apps_provider.dart';
import 'package:obtainium/providers/logs_provider.dart';
import 'package:obtainium/providers/notifications_provider.dart';
import 'package:obtainium/providers/settings_provider.dart';
import 'package:obtainium/providers/source_provider.dart';
import 'package:obtainium/main.dart';
import 'package:provider/provider.dart';

class HomePage extends StatefulWidget {
Expand Down Expand Up @@ -231,6 +233,181 @@ class _HomePageState extends State<HomePage> {
appsPageKey.currentState?.openAppById(appId);
}

Future<void> maybeExit(Uri uri) async {
final headless = uri.queryParameters['headless'] == 'true' ||
uri.queryParameters['exit'] == 'true';
if (headless && mounted) {
await Future.delayed(const Duration(milliseconds: 500));
if (mounted) {
SystemNavigator.pop();
}
}
}

Future<void> handleUpdateLink(Uri uri) async {
final path = uri.path.toLowerCase();
final isAll = path == '/all' || path == '/update';
final forceAll = uri.queryParameters['forceAll'] != 'false';
final autoInstall =
uri.queryParameters['autoInstall'] == 'true' || isAll;
final headless = uri.queryParameters['headless'] == 'true' ||
(isAll && uri.queryParameters['headless'] != 'false');
final silentOnly = uri.queryParameters['silentOnly'] == 'true' ||
uri.queryParameters['silent'] == 'true';
final specificIds =
uri.queryParameters['appId']?.split(',').where((s) => s.isNotEmpty).toList();

await waitUntil(
() => !appsProvider.loadingApps,
interval: const Duration(milliseconds: 10),
maxAttempts: 500,
);

Future<List<String>> _filterSilent(List<String> ids) async {
if (!silentOnly) return ids;
final results = await Future.wait(ids.map((id) async {
final appInMem = appsProvider.apps[id];
if (appInMem == null) return null;
final silent = await appsProvider.canInstallSilentlyInBackground(
appInMem.app);
if (!silent) {
unawaited(
LogsProvider().add(
'Skipping ${appInMem.app.name}: cannot install silently',
level: LogLevel.warning,
),
);
}
return silent ? id : null;
}));
return results.whereType<String>().toList();
}

final bool hasSpecificIds =
!isAll && specificIds != null && specificIds.isNotEmpty;

final updates = hasSpecificIds
? await appsProvider
.checkUpdates(specificIds: specificIds, forceAll: forceAll)
.catchError((e) {
unawaited(
LogsProvider().add(
'Deep-link update check failed: $e',
level: LogLevel.error,
),
);
return <App>[];
})
: await appsProvider.checkUpdates(forceAll: forceAll).catchError((e) {
unawaited(
LogsProvider().add(
'Deep-link update check failed: $e',
level: LogLevel.error,
),
);
return <App>[];
});

if (autoInstall) {
var ids = hasSpecificIds
? updates.map((a) => a.id).toList()
: appsProvider.findAppIdsWithPendingUpdates(installedOnly: true);
ids = await _filterSilent(ids);
if (ids.isNotEmpty) {
unawaited(
appsProvider
.downloadAndInstallLatestApps(
ids,
appNavigatorKey.currentContext,
notificationsProvider: context.read<NotificationsProvider>(),
)
.catchError((e) {
unawaited(
LogsProvider().add(
'Deep-link install failed: $e',
level: LogLevel.error,
),
);
return <String>[];
}),
);
}
}

if (mounted) {
showMessage(
updates.isNotEmpty
? '${tr('updatesAvailable')}: ${updates.length}'
: tr('noNewUpdates'),
context,
);
}

if (headless) {
await maybeExit(uri);
}
}

Future<void> handleSettingsLink(Uri uri) async {
final path = uri.path.toLowerCase();
final segments = path.split('/').where((s) => s.isNotEmpty).toList();
if (segments.isEmpty) {
throw ObtainiumError(tr('unknown'));
}
final setting = segments[0];

if (setting == 'installer' || setting == 'installmethod') {
final mode = uri.queryParameters['mode'];
if (mode != null &&
InstallerMode.values.any((m) => m.name == mode)) {
settingsProvider.installerMode = mode;
if (mounted) {
showMessage(
tr('installMethod') + ': ' + mode,
context,
);
}
} else {
throw ObtainiumError(tr('invalidInput'));
}
} else if (setting == 'background') {
final enabled = uri.queryParameters['enabled'];
final wifiOnly = uri.queryParameters['wifiOnly'];
final chargingOnly = uri.queryParameters['chargingOnly'];
if (enabled != null) {
settingsProvider.enableBackgroundUpdates = enabled == 'true';
}
if (wifiOnly != null) {
settingsProvider.bgUpdatesOnWiFiOnly = wifiOnly == 'true';
}
if (chargingOnly != null) {
settingsProvider.bgUpdatesWhileChargingOnly = chargingOnly == 'true';
}
if (mounted) {
showMessage(tr('saved'), context);
}
} else if (setting == 'updates') {
final interval = uri.queryParameters['interval'];
final checkOnStart = uri.queryParameters['checkOnStart'];
final parallel = uri.queryParameters['parallel'];
if (interval != null) {
settingsProvider.updateInterval = int.tryParse(interval) ?? 360;
}
if (checkOnStart != null) {
settingsProvider.checkOnStart = checkOnStart == 'true';
}
if (parallel != null) {
settingsProvider.parallelDownloads = parallel == 'true';
}
if (mounted) {
showMessage(tr('saved'), context);
}
} else {
throw ObtainiumError(tr('unknown'));
}
await maybeExit(uri);
}

Future<void> interpretLink(Uri uri) async {
final action = uri.host;
final data =
Expand Down Expand Up @@ -270,62 +447,80 @@ class _HomePageState extends State<HomePage> {
}
} else if (action == 'app' || action == 'apps') {
final dataStr = Uri.decodeComponent(data);
if (!context.mounted) return;
if (await showDialog(
context: context,
builder: (BuildContext ctx) {
return GeneratedFormModal(
title: tr(
'importX',
args: [
(action == 'app' ? tr('app') : tr('appsString'))
.toLowerCase(),
],
),
items: const [],
additionalWidgets: [
ExpansionTile(
title: Text(tr('rawJson')),
children: [
Text(
dataStr,
style: const TextStyle(fontFamily: 'monospace'),
),
// confirm=true only works when the intent came from a trusted caller
// (adb shell / system), marked by confirmedBy=system in MainActivity.kt
final autoConfirm = uri.queryParameters['confirm'] == 'true' &&
uri.queryParameters['confirmedBy'] == 'system';
final importHeadless = uri.queryParameters['headless'] == 'true' ||
uri.queryParameters['exit'] == 'true';

if (!autoConfirm) {
if (!context.mounted) return;
if (await showDialog(
context: context,
builder: (BuildContext ctx) {
return GeneratedFormModal(
title: tr(
'importX',
args: [
(action == 'app' ? tr('app') : tr('appsString'))
.toLowerCase(),
],
),
],
);
},
) !=
null) {
if (!context.mounted) return;
final ap = appsProvider;
dynamic parsedData;
try {
parsedData = jsonDecode(dataStr);
} catch (e) {
unawaited(
LogsProvider().add(
'Failed to decode deep-link JSON: $e',
level: LogLevel.error,
),
);
throw ObtainiumError(tr('invalidInput'));
}
final importPayload = jsonEncode(<String, dynamic>{
'apps': action == 'app' ? <dynamic>[parsedData] : parsedData,
});
final result = await ap.import(importPayload);
if (mounted) {
showMessage(
tr(
'importedX',
args: [plural('apps', result.key.length).toLowerCase()],
),
context,
);
items: const [],
additionalWidgets: [
ExpansionTile(
title: Text(tr('rawJson')),
children: [
Text(
dataStr,
style: const TextStyle(fontFamily: 'monospace'),
),
],
),
],
);
},
) ==
null) {
return;
}
}

if (!context.mounted) return;
final ap = appsProvider;
dynamic parsedData;
try {
parsedData = jsonDecode(dataStr);
} catch (e) {
unawaited(
LogsProvider().add(
'Failed to decode deep-link JSON: $e',
level: LogLevel.error,
),
);
throw ObtainiumError(tr('invalidInput'));
}
final importPayload = jsonEncode(<String, dynamic>{
'apps': action == 'app' ? <dynamic>[parsedData] : parsedData,
});
final result = await ap.import(importPayload);
if (mounted) {
showMessage(
tr(
'importedX',
args: [plural('apps', result.key.length).toLowerCase()],
),
context,
);
}
if (importHeadless) {
await maybeExit(uri);
}
} else if (action == 'update') {
await handleUpdateLink(uri);
} else if (action == 'settings') {
await handleSettingsLink(uri);
} else {
throw ObtainiumError(tr('unknown'));
}
Expand Down