Add edit menu to enable select all shortcut in macOS file dialog#668
Open
for13to1 wants to merge 1 commit into
Open
Add edit menu to enable select all shortcut in macOS file dialog#668for13to1 wants to merge 1 commit into
for13to1 wants to merge 1 commit into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, the native file dialog (
NSOpenPanel) does not handle keyboard shortcuts likeCmd+A(Select All) on its own. It requires the parent application to have an Edit menu with a corresponding action linked to theselectAll:selector.This PR adds a standard Edit menu (Undo, Redo, Cut, Copy, Paste, and Select All) to
MainWindow.Each action is dynamically dispatched to the currently focused widget via
QMetaObject::invokeMethodusing their platform-standardQKeySequence(which makes the shortcut work in the native file dialog and ensures it is locale-safe).