Skip to content

t*: remove duplicate ldflags#295242

Merged
chenrui333 merged 111 commits into
mainfrom
t-remove-duplicate-ldflags
Jul 26, 2026
Merged

t*: remove duplicate ldflags#295242
chenrui333 merged 111 commits into
mainfrom
t-remove-duplicate-ldflags

Conversation

@botantony

Copy link
Copy Markdown
Member

Homebrew/brew#23299


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

@botantony botantony added the CI-no-bottles Merge without publishing bottles label Jul 25, 2026
@github-actions github-actions Bot added the go Go use is a significant feature of the PR or issue label Jul 25, 2026
@stefanb stefanb added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jul 25, 2026
@botantony botantony added the long build Set a long timeout for formula testing label Jul 25, 2026
botantony added 25 commits July 26, 2026 00:50
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
@botantony
botantony force-pushed the t-remove-duplicate-ldflags branch from 19a50a8 to 5c071b1 Compare July 25, 2026 22:51
@chenrui333
chenrui333 enabled auto-merge July 25, 2026 23:29
@botantony

Copy link
Copy Markdown
Member Author

#291278

botantony added 10 commits July 26, 2026 03:12
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
@botantony
botantony force-pushed the t-remove-duplicate-ldflags branch from 5c071b1 to 93b5730 Compare July 26, 2026 01:12
@daeho-ro

Copy link
Copy Markdown
Member

I think it will be fine to merge, right?

@botantony botantony added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jul 26, 2026
@chenrui333
chenrui333 added this pull request to the merge queue Jul 26, 2026
Merged via the queue into main with commit 56984cc Jul 26, 2026
34 of 41 checks passed
@chenrui333
chenrui333 deleted the t-remove-duplicate-ldflags branch July 26, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. go Go use is a significant feature of the PR or issue long build Set a long timeout for formula testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants