Skip to content

Remove RGF from HerbInterpret; just use Core.eval - #54

Open
THinnerichs wants to merge 3 commits into
masterfrom
perf/improve_bv
Open

Remove RGF from HerbInterpret; just use Core.eval#54
THinnerichs wants to merge 3 commits into
masterfrom
perf/improve_bv

Conversation

@THinnerichs

@THinnerichs THinnerichs commented Jun 25, 2026

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.36842% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.60%. Comparing base (b5a6c5c) to head (6a14cc0).

Files with missing lines Patch % Lines
src/make_interpret.jl 87.36% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   69.11%   75.60%   +6.49%     
==========================================
  Files           3        3              
  Lines         204      246      +42     
==========================================
+ Hits          141      186      +45     
+ Misses         63       60       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

Benchmark Results

master 6a14cc0... master / 6a14cc0...
interpret/Random Expressions 0.106 ± 0.0032 ms 0.107 ± 0.004 ms 0.991 ± 0.047
time_to_load 0.0855 ± 0.00039 s 0.0847 ± 0.0017 s 1.01 ± 0.02

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@THinnerichs
THinnerichs requested a review from ReubenJ July 16, 2026 08:51
@THinnerichs THinnerichs self-assigned this Jul 16, 2026
@THinnerichs THinnerichs added the bug Something isn't working label Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant