Repository navigation
Fix QLayout warnings at startup - #1257
Merged
Merged
Conversation
McA
commented
Oct 20, 2026
McA
commented
Contributor
- do not pass the statuswindow as parent to the layouts of ServerVBox, its header and StatusBar - Qt only warns and drops the parent again because the statuswindow already has a layout
- remove the second addLayout() in create_server_vboxes() as create_server_vbox() already adds the vbox
- do not pass the statuswindow as parent to the layouts of ServerVBox, its header and StatusBar - Qt only warns and drops the parent again because the statuswindow already has a layout - remove the second addLayout() in create_server_vboxes() as create_server_vbox() already adds the vbox
Owner
|
Thanks McA! Missing the silly error already... |
Contributor
Author
|
Hallo Henri,
bekomst Du diese Nachricht?
Gruß
McA
Am 20.10.26 um 22:37 schrieb Henri Wahl:
… *HenriWahl* left a comment (HenriWahl/Nagstamon#1257)
<#1257 (comment)>
Thanks McA! Missing the silly error already...
—
Reply to this email directly, view it on GitHub
<#1257?email_source=notifications&email_token=AA7UPCMLKXOKHP5ODLTC7IL5U7EKHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZQGA4TIMBVGUYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6300940550>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7UPCJDQD26LU5Y7RSW7CD5U7EKHAVCNFSNUABDKJSXA33TNF2G64TZHM3TCMBZHAYTQO2JONZXKZJ3GU4TGOJYHA2TOMRWUF3AE>.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AA7UPCP3DPZOGMEIWOQIQKT5U7EKHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZQGA4TIMBVGUYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AA7UPCPJTDY5S3M4JVNKDLT5U7EKHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZQGA4TIMBVGUYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
HenriWahl
pushed a commit
that referenced
this pull request
Oct 25, 2026
- do not pass the statuswindow as parent to the layouts of ServerVBox, its header and StatusBar - Qt only warns and drops the parent again because the statuswindow already has a layout - remove the second addLayout() in create_server_vboxes() as create_server_vbox() already adds the vbox Co-authored-by: Andreas Mock <4147081+McA@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.