Highlight active toolbar toggles and simplify the incognito key - #2695
Open
MiMoHo wants to merge 3 commits into
Open
Highlight active toolbar toggles and simplify the incognito key#2695MiMoHo wants to merge 3 commits into
MiMoHo wants to merge 3 commits into
Conversation
When the toolbar is open, the incognito toolbar key already indicates incognito mode, yet the leftmost expand key also switched to the incognito icon, so it was shown twice. Keep the expand-key indicator only while the toolbar is collapsed (where it is the sole cue) and use the normal arrow while the toolbar is expanded. Refs HeliBorg#2440 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> (cherry picked from commit 5caf46d)
Active toolbar toggles (autocorrect, one-handed, split, incognito) and the numpad/D-pad/floating mode keys are tinted with the theme accent while active, instead of the previous behaviour that tinted the idle toggles. States are read fresh from prefs and refreshed on keyboard mode changes. The incognito toolbar key now uses a single plain glasses icon and is only re-tinted (no chevron, no crossed-out variant); the chevron+glasses combo remains only as the collapsed expand-key incognito indicator, so the key chooser shows the plain glasses. Long-press shows a tooltip (API 26+) when quick-pin is off. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…eliBorg#2220) The collapsed expand key showed an incognito indicator that could not be hidden and did nothing on tap when the toolbar was not expandable (HeliBorg#2220). Since the incognito toolbar key can be pinned to show the state in the collapsed strip, the separate indicator is redundant; the expand key is now always the plain toolbar arrow, and it is only shown when it can actually toggle the toolbar. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
I tested it, and the keys remain highlight for me :/ And why highlight other keys? 😐 In #2440, I meant completely removing that highlight. Highlighting the active one-handed mode or the split keyboard key makes no sense, as this is visible on the keyboard itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Active toolbar toggles (autocorrect, one-handed, split, incognito) and the numpad/D-pad/floating mode keys are now tinted with the theme accent while active, instead of the previous behaviour that tinted the idle toggles. The incognito toolbar key uses a single plain glasses icon and is only re-tinted (no chevron, no crossed-out variant); the chevron+glasses combo remains only as the collapsed expand-key indicator, so the key chooser shows the plain glasses. Long-press shows a tooltip (API 26+) when quick-pin is off.
Addresses the "Forest: some toolbar keys look highlighted" point of #2440 and improves incognito clarity (#2277, #1630). It also suggests a way to close #2220 (see note below).
Note on #2220: the collapsed expand key is force-shown just to display the incognito indicator, even when the toolbar isn't expandable — so with a minimal toolbar it can't be hidden and does nothing on tap. A possible follow-up is to show that indicator only when the toolbar is expandable.
Flagging it as a design call rather than bundling it here.