Make the floating keyboard's drag/resize handles reachable - #2692
Open
MiMoHo wants to merge 1 commit into
Open
Conversation
The touchable region used the configured mFloatingHeight, which is smaller than the rendered keyboard, so the bottom drag/resize handles fell outside it and touches passed through to the app behind. Use the floating input view's measured height (strip + keyboard + handles) instead. On Android 15+ the IME draws edge-to-edge behind the navigation bar, so subtract the nav-bar inset to keep the handles above it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The floating keyboard's bottom drag/resize handles were often unreachable — the IME touchable region was computed from the configured
mFloatingHeight, which is smaller than the rendered keyboard, so the handles fell outside it and touches passed through to the app behind. This uses the floating input view's measured height instead. On Android 15+ (edge-to-edge, IME draws behind the navigation bar) it also subtracts the nav-bar inset so the handles stay above it.Fixes #2610, #2680.