Repository navigation
fix(curation): refuse a blank pipeline_version in stale_episodes - #799
Conversation
[Medium impact] The PR appears safe to merge; no actionable issues were found.
|
|
Hi maintainers, Thank you for the review! I can see that all five checks have passed and the PR has received an approving review. I have an academic submission deadline in approximately 6 hours. If everything looks good from the maintainers' side, could you kindly consider merging this PR before then? I would really appreciate your help. Thank you! |
|
Hi maintainers, I hope you're doing well. I wanted to kindly request a review of this PR. I have an academic submission deadline in approximately 2 hours. I noticed that one workflow is awaiting maintainer approval. Could someone please approve the workflow and review the PR when possible? I'm happy to address any requested changes immediately. I would really appreciate your help. Thank you for your time and for maintaining rockpack! |
|
Hi maintainers,
I hope you're doing well.
I wanted to kindly request a review of this PR. I have an academic
submission deadline in approximately 2 hours.
I noticed that one workflow is awaiting maintainer approval. Could someone
please approve the workflow and review the PR when possible?
I'm happy to address any requested changes immediately.
I would really appreciate your help. Thank you for your time and for
maintaining rockpack!
…On Thu, 19 Nov, 2026, 12:48 pm greptile-apps[bot], ***@***.***> wrote:
***@***.***[bot]* approved this pull request.
—
Reply to this email directly, view it on GitHub
<#799?email_source=notifications&email_token=CJDZSOHRNTNBX6Q6CK4SRUT5Z2NFZA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKOJXGA4DINZSGI22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-5970847225>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CJDZSOED2GNYOTUG2YLAI2L5Z2NFZAVCNFSNUABGKJSXA33TNF2G64TZHMYTGMZYGY4DCOBTHA5US43TOVSTWNRUHA2DIOJRGI2DHILWAI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Summary
hflow stale --pipeline-version ''(or a whitespace-only value) now exits 2 withstale: pipeline_version must not be blankinstead of listing episodes.stale_episodes()raisesValueErrorfor the same input.Why
A blank version is never equal to a cataloged
pipeline_version, so every episode was reported as stale. Sincestaleoutput is meant to be piped intohflow ingest, an empty shell variable (--pipeline-version "$VER") would queue the whole corpus for reprocessing. The check lives instale_episodes()so library callers get it too, and the CLI already turns thatValueErrorinto exit code 2.Validation
uv run pytest -q tests/test_catalog_curation.py tests/test_cli.py: 220 passed. The 4 new tests fail without the fix.uv run pytest -q -n 8 --ignore=tests/test_lerobot_export.py: 2599 passed. The only failures are intests/test_lerobot_workflow.py, and they fail onmaintoo in my environment.uv run ruff check,uv run ruff format --check,uv run ty check: all pass.Checklist
uv run ruff check --fix,uv run ruff format, anduv run ty check.AI-assisted with Claude Code. I reviewed the change and the test results.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.