Skip to content

fix(curation): refuse a blank pipeline_version in stale_episodes - #799

Open
harshaadimulam22-creator wants to merge 1 commit into
Hebbian-Robotics:mainfrom
harshaadimulam22-creator:stale-reject-empty-pipeline-version
Open

harshaadimulam22-creator wants to merge 1 commit into
Hebbian-Robotics:mainfrom
harshaadimulam22-creator:stale-reject-empty-pipeline-version

Conversation

@harshaadimulam22-creator

@harshaadimulam22-creator harshaadimulam22-creator commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

hflow stale --pipeline-version '' (or a whitespace-only value) now exits 2 with stale: pipeline_version must not be blank instead of listing episodes. stale_episodes() raises ValueError for the same input.

Why

A blank version is never equal to a cataloged pipeline_version, so every episode was reported as stale. Since stale output is meant to be piped into hflow ingest, an empty shell variable (--pipeline-version "$VER") would queue the whole corpus for reprocessing. The check lives in stale_episodes() so library callers get it too, and the CLI already turns that ValueError into exit code 2.

Validation

  • uv run pytest -q tests/test_catalog_curation.py tests/test_cli.py: 220 passed. The 4 new tests fail without the fix.
  • uv run pytest -q -n 8 --ignore=tests/test_lerobot_export.py: 2599 passed. The only failures are in tests/test_lerobot_workflow.py, and they fail on main too in my environment.
  • uv run ruff check, uv run ruff format --check, uv run ty check: all pass.

Checklist

  • I added or updated outcome-focused tests for changed business logic.
  • I updated documentation for changed behavior, flags, formats, or requirements.
  • I ran uv run ruff check --fix, uv run ruff format, and uv run ty check.
  • I ran the relevant pytest suite.
  • I did not add recordings, generated media, credentials, private URLs, or runtime artifacts.
  • I preserved stored-data compatibility or documented an explicit version change.

AI-assisted with Claude Code. I reviewed the change and the test results.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@greptile-apps

greptile-apps Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Rejects empty or whitespace-only pipeline versions before listing stale episodes, preventing accidental full-corpus reprocessing.

  • The stale lookup rejects blank pipeline versions.

No actionable issues found.

Reviews (1) · Last reviewed commit: "fix(curation): refuse a blank pipeline_v..." · Reviewed by Greptile

@harshaadimulam22-creator

Copy link
Copy Markdown
Contributor Author

Hi maintainers,

Thank you for the review! I can see that all five checks have passed and the PR has received an approving review.

I have an academic submission deadline in approximately 6 hours. If everything looks good from the maintainers' side, could you kindly consider merging this PR before then?

I would really appreciate your help. Thank you!

@harshaadimulam22-creator

Copy link
Copy Markdown
Contributor Author

Hi maintainers,

I hope you're doing well.

I wanted to kindly request a review of this PR. I have an academic submission deadline in approximately 2 hours.

I noticed that one workflow is awaiting maintainer approval. Could someone please approve the workflow and review the PR when possible?

I'm happy to address any requested changes immediately.

I would really appreciate your help. Thank you for your time and for maintaining rockpack!

@harshaadimulam22-creator

Copy link
Copy Markdown
Contributor Author

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant