Skip to content

test(lint): enable ruff PT018 and split composite assertions - #793

Merged
kstonekuan merged 1 commit into
Hebbian-Robotics:mainfrom
tridev-tej:fix-issue-791
Nov 16, 2026
Merged

kstonekuan merged 1 commit into
Hebbian-Robotics:mainfrom
tridev-tej:fix-issue-791

Conversation

@tridev-tej

@tridev-tej tridev-tej commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

adds PT018 to ruff select and splits all 49 assert a and b findings into ordered asserts, so a failure names the condition that broke.

Why

clearer test failures; ci's ruff check now enforces it. no behavior or test-case changes.

Validation

uv run ruff check, ruff format, ty check, pytest -q -n 4 (2636 passed, 8 skipped, ffmpeg 8.1). uv.lock unchanged.

Fixes #791


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Enables Ruff PT018 and replaces composite assertions with separate, ordered checks across the test suites.

  • Test failures point to one failed condition at a time.

Reviews (1) · Last reviewed commit: "test(lint): enable ruff PT018 and split ..." · Reviewed by Greptile

@kstonekuan kstonekuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. 49 PT018 findings on main, 0 on your branch (the three example configs too), 2636 passed. Thanks!

@kstonekuan
kstonekuan merged commit d9a793c into Hebbian-Robotics:main Nov 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Ruff composite-assertion checks and fix all findings

2 participants