Repository navigation
test(lint): enable ruff PT018 and split composite assertions - #793
Merged
Merged
Conversation
Contributor
[Low impact] The PR appears safe to merge.
|
kstonekuan
approved these changes
Nov 16, 2026
kstonekuan
left a comment
Contributor
There was a problem hiding this comment.
LGTM, merging. 49 PT018 findings on main, 0 on your branch (the three example configs too), 2636 passed. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adds PT018 to ruff select and splits all 49
assert a and bfindings into ordered asserts, so a failure names the condition that broke.Why
clearer test failures; ci's
ruff checknow enforces it. no behavior or test-case changes.Validation
uv run ruff check,ruff format,ty check,pytest -q -n 4(2636 passed, 8 skipped, ffmpeg 8.1). uv.lock unchanged.Fixes #791
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.