Repository navigation
fix: align sampled RGB frames across decode gaps - #764
kstonekuan merged 13 commits into
Conversation
[Medium impact] The PR appears safe to merge; no blocking issues remain.
|
kstonekuan
left a comment
There was a problem hiding this comment.
Could you cover and fix non-integer sampling rates? On an intact three-second, 30 fps testsrc2 clip, rgb_frames(..., frames_per_second=3.0000049) returns only sample 0 here; main returns nine frames. At 3.0 fps, both return all nine.
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
Hi, thanks for the review. I’ve updated the branch to:
|
kstonekuan
left a comment
There was a problem hiding this comment.
Could you add coverage through the MediaPipe path for a missing sampling tick? The decoder regression checks the retained frame indices, but it doesn't verify that later detector timestamps and absence intervals keep their original times.
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
Thanks for the feedback. I added coverage through the MediaPipe path for a missing sampling tick. The test verifies later detector timestamps stay at their original times and the absence interval uses the original source timestamps. The full suite passes: 2,628 passed, 9 skipped. |
kstonekuan
left a comment
There was a problem hiding this comment.
Could you also exclude the concealed picture after the lost keyframe? On the existing IDR-100 fixture, sample 108 is labelled as source frame 109 but its pixels read as 111. #767 now rejects that picture in the episode accessors.
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
Thanks for the follow-up. I’ve pushed commit |
|
I also fixed the opening-gap case in commit |
kstonekuan
left a comment
There was a problem hiding this comment.
Could you keep no_hand_detected intervals out of skipped sampling ticks? In test_missing_sampling_tick_keeps_detector_and_absence_times, tick 1 has no decoded sample, but the asserted interval runs from 0 to 3 seconds and includes it.
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
I fixed the skipped-tick interval issue in commit |
kstonekuan
left a comment
There was a problem hiding this comment.
Could you bound the new frame-hash decode and cover a stalled FFmpeg process? _decoded_frame_hashes blocks while reading stdout and waits without a timeout, so a hung decoder can leave the measurement running indefinitely.
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
I addressed this in commit |
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
The CI failure was the package-boundary test; |
kstonekuan
left a comment
There was a problem hiding this comment.
Could you also bound the new ffprobe calls in _probe_frame_rate and _probe_keyframe_indices? Both use subprocess.run without a timeout or output limit, so a stalled probe can still leave the measurement running indefinitely. Please cover a stalled probe too.
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
kstonekuan
left a comment
There was a problem hiding this comment.
Thanks for working through this! Ruff, formatting, ty, and the full suite pass locally (2,637 passed, 47 skipped).
Summary
Fixes #733
Validation
Need help on this PR? Tag
@codesmith-botwith what you need.