Repository navigation
fix: update psycopg - #232
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
On my machine, the last release was fine. In azure, it didn't work. This is because SQLAlchemy updated so you either need to have psycopg 3 installed, or specify psycopg2 as the postgres driver. I opted to pin SQLAlchemy >= 2.1 and to upgrade psycopg. As psycopg isn't directly called anywhere, there wasn't much else to do!
The releases weren't getting tagged properly, so now each of the container build actions gets a semver release job, which I think should work ok
Related Issues or other material
Related #231
Closes #231
Screenshots, example outputs/behaviour etc.
✅ Added/updated tests?
[optional] What gif best describes this PR or how it makes you feel?